Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externally_connectable legacy API POC #317

Closed
wants to merge 2 commits into from

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Apr 9, 2024

Meant to enable connecting to extension over externally_connectable.

  • Disables automatic usage of window.ethereum provider on page load
  • Adds form for entering and connecting to extension by ID via externally_connectable

See: https://github.com/MetaMask/MetaMask-planning/issues/2325
See: MetaMask/metamask-extension#23920

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] Transitive: network +24 5.07 MB metamaskbot
npm/@scure/[email protected] None 0 80.4 kB paulmillr
npm/[email protected] None +1 265 kB mysticatea
npm/[email protected] None 0 10.5 kB lgbot
npm/[email protected] environment 0 124 kB matteo.collina
npm/[email protected] None 0 198 kB addons-robot

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Network access npm/[email protected]
Network access npm/[email protected]
Network access npm/[email protected]
New author npm/[email protected]
New author npm/@metamask/[email protected]

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant